Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object: fix with prefix #2021

Merged
merged 1 commit into from
May 16, 2022
Merged

object: fix with prefix #2021

merged 1 commit into from
May 16, 2022

Conversation

zhijian-pro
Copy link
Contributor

Storage of type whithprfix should behave in the same way as the storage it wraps.

@codecov-commenter
Copy link

Codecov Report

Merging #2021 (50b3e1c) into main (c361878) will increase coverage by 0.11%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2021      +/-   ##
==========================================
+ Coverage   61.52%   61.63%   +0.11%     
==========================================
  Files         137      137              
  Lines       23837    23837              
==========================================
+ Hits        14665    14693      +28     
+ Misses       7452     7430      -22     
+ Partials     1720     1714       -6     
Impacted Files Coverage Δ
pkg/object/prefix.go 69.76% <0.00%> (ø)
pkg/chunk/cached_store.go 75.68% <0.00%> (-0.55%) ⬇️
pkg/meta/redis.go 71.88% <0.00%> (+0.04%) ⬆️
pkg/meta/sql.go 65.00% <0.00%> (+0.09%) ⬆️
pkg/meta/tkv.go 76.78% <0.00%> (+0.43%) ⬆️
pkg/vfs/writer.go 79.66% <0.00%> (+1.01%) ⬆️
pkg/vfs/reader.go 80.29% <0.00%> (+3.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c361878...50b3e1c. Read the comment docs.

@zhijian-pro zhijian-pro changed the title fix with prefix object: fix with prefix May 16, 2022
@zhijian-pro zhijian-pro marked this pull request as ready for review May 16, 2022 02:27
@zhijian-pro zhijian-pro requested a review from davies May 16, 2022 02:27
@davies davies merged commit 9090714 into main May 16, 2022
@davies davies deleted the fix_with_prefix branch May 16, 2022 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants