Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check prefix and marker with returned key from S3 #2040

Merged
merged 1 commit into from
May 18, 2022
Merged

Conversation

davies
Copy link
Contributor

@davies davies commented May 18, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #2040 (15a74ed) into main (3558e72) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2040      +/-   ##
==========================================
- Coverage   61.60%   61.52%   -0.09%     
==========================================
  Files         137      137              
  Lines       23836    23854      +18     
==========================================
- Hits        14685    14675      -10     
- Misses       7436     7458      +22     
- Partials     1715     1721       +6     
Impacted Files Coverage Δ
pkg/object/s3.go 42.65% <100.00%> (-0.63%) ⬇️
pkg/vfs/reader.go 77.18% <0.00%> (-3.11%) ⬇️
pkg/object/sharding.go 68.22% <0.00%> (-1.30%) ⬇️
pkg/vfs/writer.go 78.64% <0.00%> (-1.02%) ⬇️
pkg/object/swift.go 3.12% <0.00%> (-0.16%) ⬇️
pkg/meta/sql.go 64.89% <0.00%> (-0.10%) ⬇️
pkg/sync/sync.go 46.47% <0.00%> (-0.05%) ⬇️
pkg/object/bos.go 1.52% <0.00%> (-0.04%) ⬇️
pkg/chunk/cached_store.go 76.37% <0.00%> (+0.13%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3558e72...15a74ed. Read the comment docs.

@davies davies requested a review from zhijian-pro May 18, 2022 08:17
@davies davies merged commit 438d40a into main May 18, 2022
@davies davies deleted the check_marker branch May 18, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants