Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk/java: don't reuse fd in Java SDK #2122

Merged
merged 1 commit into from
May 27, 2022
Merged

sdk/java: don't reuse fd in Java SDK #2122

merged 1 commit into from
May 27, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented May 27, 2022

closes #2116

@codecov-commenter
Copy link

Codecov Report

Merging #2122 (83c11a8) into main (35918c3) will decrease coverage by 0.10%.
The diff coverage is 78.78%.

@@            Coverage Diff             @@
##             main    #2122      +/-   ##
==========================================
- Coverage   61.87%   61.76%   -0.11%     
==========================================
  Files         138      138              
  Lines       24839    24844       +5     
==========================================
- Hits        15368    15346      -22     
- Misses       7659     7682      +23     
- Partials     1812     1816       +4     
Impacted Files Coverage Δ
cmd/rmr.go 58.73% <0.00%> (-1.93%) ⬇️
pkg/fuse/fuse.go 78.10% <0.00%> (+0.50%) ⬆️
pkg/meta/sql_lock.go 71.52% <ø> (ø)
pkg/meta/tkv_lock.go 82.51% <ø> (ø)
pkg/meta/sql.go 65.65% <78.94%> (-0.13%) ⬇️
pkg/meta/base.go 69.89% <100.00%> (+0.18%) ⬆️
pkg/meta/redis.go 71.40% <100.00%> (ø)
pkg/meta/tkv.go 76.71% <100.00%> (+0.03%) ⬆️
pkg/vfs/reader.go 77.18% <0.00%> (-2.56%) ⬇️
pkg/meta/tkv_mem.go 85.54% <0.00%> (-1.74%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973b08c...83c11a8. Read the comment docs.

@davies davies merged commit 549ee34 into main May 27, 2022
@davies davies deleted the dont_reuse_fd branch May 27, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unknown write accesslog when execute only read sql
2 participants