Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix path in Windows #4138

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix path in Windows #4138

merged 2 commits into from
Nov 7, 2023

Conversation

zhijian-pro
Copy link
Contributor

image

@davies davies changed the title cmd/sync: use the linux separator in file.go fix path in Windows Nov 6, 2023
@davies
for virtual path, we should use path.
f9cbb0d 
for local path, we should use filepath.
@zhijian-pro
Copy link
Contributor Author

no problem with the test

@davies davies merged commit 195ee22 into main Nov 7, 2023
35 checks passed
@davies davies deleted the fix-sync-windows branch November 7, 2023 12:59
SandyXSD pushed a commit that referenced this pull request Nov 24, 2023
@zhijian-pro @SandyXSD
fix path in Windows (#4138)
4e9183b
davies pushed a commit that referenced this pull request Nov 25, 2023
@zhijian-pro @davies
fix path in Windows (#4138)
fe6ae61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davies davies Awaiting requested review from davies

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhijian-pro @davies