Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sync: copying times, owner and mode not follow link #4151

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Hexilee
Copy link
Contributor

@Hexilee Hexilee commented Nov 8, 2023

close #4150

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (cea8330) 55.49% compared to head (de45e56) 55.54%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4151      +/-   ##
==========================================
+ Coverage   55.49%   55.54%   +0.04%     
==========================================
  Files         153      153              
  Lines       38902    38923      +21     
==========================================
+ Hits        21590    21620      +30     
+ Misses      14890    14875      -15     
- Partials     2422     2428       +6     
Files Coverage Δ
pkg/object/file.go 75.20% <100.00%> (-0.31%) ⬇️
cmd/object.go 36.42% <0.00%> (ø)
pkg/fs/fs.go 78.24% <66.66%> (-0.14%) ⬇️
pkg/sync/sync.go 42.84% <75.00%> (+0.06%) ⬆️
pkg/object/file_unix.go 88.00% <80.00%> (-12.00%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies merged commit 562c989 into main Nov 15, 2023
35 checks passed
@davies davies deleted the fix/sync-files-mode branch November 15, 2023 02:37
SandyXSD pushed a commit that referenced this pull request Nov 24, 2023
davies pushed a commit that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync file: Chown, Chmod and Chtimes do not works well with symlink
2 participants