Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert current write lock into read lock #4179

Merged
merged 1 commit into from
Nov 20, 2023
Merged

convert current write lock into read lock #4179

merged 1 commit into from
Nov 20, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Nov 20, 2023

flock should convert current exclusive lock into a shared lock.

Copy link

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b7be0cf) 56.01% compared to head (269e900) 56.05%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4179      +/-   ##
==========================================
+ Coverage   56.01%   56.05%   +0.04%     
==========================================
  Files         153      153              
  Lines       39019    39020       +1     
==========================================
+ Hits        21855    21872      +17     
+ Misses      14712    14704       -8     
+ Partials     2452     2444       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies requested a review from SandyXSD November 20, 2023 05:09
@SandyXSD
Copy link
Contributor

https://man7.org/linux/man-pages/man2/flock.2.html

A process may hold only one type of lock (shared or exclusive) on
a file. Subsequent flock() calls on an already locked file will
convert an existing lock to the new lock mode.

@SandyXSD SandyXSD merged commit e2f5b0d into main Nov 20, 2023
35 checks passed
@SandyXSD SandyXSD deleted the flock_convert branch November 20, 2023 07:39
SandyXSD pushed a commit that referenced this pull request Nov 24, 2023
flock should convert current exclusive lock into a shared lock.
davies added a commit that referenced this pull request Nov 24, 2023
flock should convert current exclusive lock into a shared lock.
SandyXSD pushed a commit that referenced this pull request Nov 24, 2023
flock should convert current exclusive lock into a shared lock.
davies added a commit that referenced this pull request Nov 25, 2023
flock should convert current exclusive lock into a shared lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants