Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows fs truncate return syscall.EBADF #4238

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

AChangFeng
Copy link
Contributor

@AChangFeng AChangFeng commented Dec 6, 2023

  1. fix windows fs truncate return syscall.EBADF
  2. fix setup-hdfs.sh: upgrate hdfs verion from 2.10.1 to 2.10.2, because hadoop-2.10.1.tar.gz is not available in https://dlcdn.apache.org/hadoop/common

BTW, It’s difficult to get a PR passed through all checks. I pushed my branch without any changes for 6 times to get my PR passed through all checks.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1a82b80) 55.72% compared to head (670b00d) 55.72%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4238   +/-   ##
=======================================
  Coverage   55.72%   55.72%           
=======================================
  Files         154      154           
  Lines       39569    39569           
=======================================
+ Hits        22049    22051    +2     
+ Misses      15053    15052    -1     
+ Partials     2467     2466    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AChangFeng AChangFeng force-pushed the fix-winfsp-truncate branch 3 times, most recently from 1aee194 to fac7a84 Compare December 6, 2023 10:16
@davies davies merged commit 69de99e into juicedata:main Dec 7, 2023
32 checks passed
@AChangFeng AChangFeng deleted the fix-winfsp-truncate branch December 7, 2023 10:16
@davies
Copy link
Contributor

davies commented Dec 7, 2023

The failed action is caused by github, sorry for the inconvenience.

@davies davies added backport-1.0 Backport to release-1.0 branch backport-1.1 labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch backport-1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants