Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: slowdown dump process to reduce memory usage #4253

Merged
merged 2 commits into from
Dec 12, 2023
Merged

meta: slowdown dump process to reduce memory usage #4253

merged 2 commits into from
Dec 12, 2023

Conversation

davies
Copy link
Contributor

@davies davies commented Dec 12, 2023

close #4252

@davies davies requested a review from SandyXSD December 12, 2023 09:29
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (71fdb17) 55.73% compared to head (a9336db) 55.54%.

Files Patch % Lines
pkg/meta/tkv.go 16.66% 9 Missing and 1 partial ⚠️
pkg/meta/sql.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4253      +/-   ##
==========================================
- Coverage   55.73%   55.54%   -0.19%     
==========================================
  Files         153      120      -33     
  Lines       39516    31113    -8403     
==========================================
- Hits        22023    17281    -4742     
+ Misses      15022    11791    -3231     
+ Partials     2471     2041     -430     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/meta/sql.go Outdated Show resolved Hide resolved
Copy link

Mutate Test Report
pkg/meta/load_dump_test.go-1-1: score:0.00 failed:0, passed:0, compile error:0, out of coverage:0, skip by comment:0, others:0
Job detail: https://github.com/juicedata/juicefs/actions/runs/7179829304/job/19550882724

Usage: https://github.com/juicedata/juicefs/blob/main/.github/scripts/mutate/how_to_use_mutate_test.md

@davies davies merged commit 6f2440c into main Dec 12, 2023
31 of 35 checks passed
@davies davies deleted the slow_dump branch December 12, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High memory usage (almost OOM) on dump with Badger
2 participants