Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fix the issue that truncated slices may never be compacted #4320

Merged
merged 6 commits into from
Jan 10, 2024

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Jan 8, 2024

No description provided.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (d1dcd95) 55.81% compared to head (7743481) 55.85%.
Report is 12 commits behind head on main.

Files Patch % Lines
pkg/meta/sql.go 70.00% 2 Missing and 1 partial ⚠️
pkg/meta/tkv.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4320      +/-   ##
==========================================
+ Coverage   55.81%   55.85%   +0.03%     
==========================================
  Files         153      153              
  Lines       39631    39757     +126     
==========================================
+ Hits        22122    22208      +86     
- Misses      15030    15056      +26     
- Partials     2479     2493      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SandyXSD SandyXSD requested a review from davies January 9, 2024 11:12
@davies davies merged commit 7b85645 into main Jan 10, 2024
27 checks passed
@davies davies deleted the fix-compact branch January 10, 2024 12:47
@davies davies added backport-1.1 backport-1.0 Backport to release-1.0 branch labels Jan 10, 2024
@lidaohang
Copy link
Contributor

mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-1.0 Backport to release-1.0 branch backport-1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants