Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compact: add new compact cmd, used for specific path (#4303) #4330

Closed

Conversation

jiefenghuang
Copy link
Contributor

Support triggering compaction of all files under a given directory #4303

@jiefenghuang jiefenghuang added the kind/feature New feature or request label Jan 10, 2024
@jiefenghuang jiefenghuang self-assigned this Jan 10, 2024
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 128 lines in your changes are missing coverage. Please review.

Comparison is base (62d9a84) 55.82% compared to head (48a0195) 41.02%.

Files Patch % Lines
cmd/compact_unix.go 80.00% 22 Missing and 8 partials ⚠️
pkg/meta/redis_lock.go 22.72% 17 Missing ⚠️
pkg/meta/utils.go 68.00% 12 Missing and 4 partials ⚠️
pkg/meta/redis.go 58.33% 14 Missing and 1 partial ⚠️
pkg/meta/tkv.go 0.00% 14 Missing ⚠️
pkg/meta/sql.go 0.00% 12 Missing ⚠️
pkg/meta/base.go 82.92% 5 Missing and 2 partials ⚠️
pkg/utils/file.go 40.00% 4 Missing and 2 partials ⚠️
cmd/gc.go 61.53% 3 Missing and 2 partials ⚠️
pkg/meta/sql_lock.go 0.00% 3 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4330       +/-   ##
===========================================
- Coverage   55.82%   41.02%   -14.81%     
===========================================
  Files         153      154        +1     
  Lines       39733    39915      +182     
===========================================
- Hits        22181    16375     -5806     
- Misses      15059    21695     +6636     
+ Partials     2493     1845      -648     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants