Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/acl: add enable-acl flag and version checking #4421

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

jiefenghuang
Copy link
Contributor

#4409

  • add enable-acl flag
  • add version checking

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 56.07%. Comparing base (a6907b0) to head (0385eb5).
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/fuse/fuse.go 36.36% 5 Missing and 2 partials ⚠️
cmd/config.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4421      +/-   ##
==========================================
+ Coverage   56.01%   56.07%   +0.06%     
==========================================
  Files         154      154              
  Lines       40076    40216     +140     
==========================================
+ Hits        22447    22551     +104     
- Misses      15120    15148      +28     
- Partials     2509     2517       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/fuse/fuse.go Outdated Show resolved Hide resolved
pkg/meta/config.go Outdated Show resolved Hide resolved
@jiefenghuang jiefenghuang marked this pull request as ready for review February 26, 2024 06:35
cmd/format.go Show resolved Hide resolved
cmd/config.go Show resolved Hide resolved
@jiefenghuang jiefenghuang marked this pull request as draft February 27, 2024 08:43
@jiefenghuang jiefenghuang marked this pull request as ready for review February 29, 2024 02:59
@jiefenghuang jiefenghuang requested a review from davies March 1, 2024 07:46
@davies davies merged commit 91b4505 into juicedata:main Mar 4, 2024
26 checks passed
@jiefenghuang jiefenghuang deleted the feat/acl-flag branch April 15, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants