Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup cache expire skip staging #4434

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

sjp00556
Copy link
Contributor

disk cache cleanup expire cache items should skip staging cache items which size is <0, otherwise it will add wrong cache.used

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (83b2ba2) to head (86681e5).

Files Patch % Lines
pkg/chunk/disk_cache.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4434      +/-   ##
==========================================
+ Coverage   56.01%   56.03%   +0.01%     
==========================================
  Files         154      154              
  Lines       40134    40136       +2     
==========================================
+ Hits        22483    22492       +9     
+ Misses      15133    15128       -5     
+ Partials     2518     2516       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davies davies requested a review from SandyXSD February 29, 2024 02:22
@SandyXSD SandyXSD merged commit f8c988f into juicedata:main Feb 29, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants