Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump: reduce memory when dump large directories from redis #4481

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

davies
Copy link
Contributor

@davies davies commented Mar 11, 2024

close #4455

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 55.34%. Comparing base (8634b3a) to head (f4d2ace).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/meta/redis.go 68.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4481      +/-   ##
==========================================
- Coverage   55.39%   55.34%   -0.05%     
==========================================
  Files         157      157              
  Lines       41218    41230      +12     
==========================================
- Hits        22831    22820      -11     
- Misses      15858    15885      +27     
+ Partials     2529     2525       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/meta/redis.go Outdated Show resolved Hide resolved
@davies davies changed the title dump: reduce memory when dump large directories dump: reduce memory when dump large directories from redis Mar 11, 2024
@davies davies merged commit fa26e0a into main Mar 12, 2024
26 checks passed
@davies davies deleted the reduce_dump_memory branch March 12, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce memory consumption of the meta backup procedure
2 participants