enhance: rm object when write failed #5154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiefenghuang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5154 +/- ##
==========================================
+ Coverage 54.27% 63.75% +9.48%
==========================================
Files 161 24 -137
Lines 43776 16006 -27770
==========================================
- Hits 23758 10205 -13553
+ Misses 17336 4424 -12912
+ Partials 2682 1377 -1305 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jiefenghuang <[email protected]>
|
Superseeds #5133 ? |
jiefenghuang
requested review from
SandyXSD and
davies
and removed request for
SandyXSD
davies
reviewed
Sep 12, 2024
| @@ -203,7 +203,9 @@ func (c *chunkWriter) commitThread() { | |||
|
|
|||
| f.Lock() | |||
| if err != 0 { | |||
| if err != syscall.ENOENT && err != syscall.ENOSPC && err != syscall.EDQUOT { | |||
| if err == syscall.ENOENT { | |||
| f.w.store.TryRemove(s.id, int(s.length)) | |||
There was a problem hiding this comment.
This is over complicated, we just start a goroutine to remove it in background
Signed-off-by: jiefenghuang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5132
remove failed objects as much as possible, non-blocking.