meta: support dir stream #5162
Merged
meta: support dir stream #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
davies
reviewed
Sep 13, 2024
davies
reviewed
Sep 13, 2024
SonglinLife
reviewed
Sep 13, 2024
Signed-off-by: jiefenghuang <[email protected]>
jiefenghuang
force-pushed
the
feat/streamdir
branch
from
394b796
to
bcc32bf
Compare
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
jiefenghuang
force-pushed
the
feat/streamdir
branch
from
cc1b475
to
a55b1b3
Compare
SandyXSD
reviewed
Sep 29, 2024
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
SandyXSD
reviewed
Sep 30, 2024
SandyXSD
reviewed
Sep 30, 2024
Signed-off-by: jiefenghuang <[email protected]>
SandyXSD
approved these changes
Sep 30, 2024
SandyXSD
reviewed
Sep 30, 2024
| return err | ||
| } | ||
|
|
||
| s = s.Table(&edge{}).In("jfs_edge.id", ids).OrderBy("jfs_edge.name") |
There was a problem hiding this comment.
These two queries for edge table can probably be merged as one.
There was a problem hiding this comment.
And ordered by id should be a simpler way.
There was a problem hiding this comment.
Need to sort by name, otherwise in some cases such as reverse order, the results may be incorrect
There was a problem hiding this comment.
The SQL query is splited which allows it to directly hit the index tree and reduce the amount of querying.
Tried to merge statements in xorm, which would lose optimization effects.
A new pull request can be proposed for optimization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5099
ref #5110