Remove unexpected read retries #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Changxin Miao <[email protected]>
davies
reviewed
Sep 27, 2024
pkg/chunk/cached_store.go
Outdated
| used := time.Since(st) | ||
| logRequest("PUT", key, "", reqID, err, used) | ||
| store.objectDataBytes.WithLabelValues("PUT", sc).Add(float64(len(p.Data))) | ||
| store.objectReqsHistogram.WithLabelValues("PUT", sc).Observe(used.Seconds()) |
There was a problem hiding this comment.
I think we should record the actual duration for the request, not bounded by timeout.
There was a problem hiding this comment.
OK, I will leave it as is.
The reason for this update is - cachedStore.delete/cachedStore.load all measure duration bounded by timeout, why cachedStore.put differs from them?
Signed-off-by: Changxin Miao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #5192 , two benefits:
io-retriesoption.