Merge pull request #13 from hpidcock/ecr

Support ECR
juju · Aug 24, 2023 · 3444523 · 3444523
2 parents 73dbf4e + cb54c60
commit 3444523
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -109,6 +109,13 @@ jobs:
           username: ${{ secrets.DOCKERHUB_USERNAME }}
           password: ${{ secrets.DOCKERHUB_TOKEN }}
 
+      - name: Login to ECR Public 
+        uses: docker/login-action@v2
+        with:
+          registry: public.ecr.aws
+          username: ${{ secrets.RELEASE_ECR_ACCESS_KEY_ID }}
+          password: ${{ secrets.RELEASE_ECR_SECRET_ACCESS_KEY }}
+
       - name: Push images
         if: ${{ success() && github.ref == 'refs/heads/master' }}
         run: |

diff --git a/images.yaml b/images.yaml
@@ -4,7 +4,8 @@ images:
     dockerfile: Dockerfile-ubuntu
     context: ubuntu-context
     registry_paths:
-      - jujusolutions/charm-base
+      - docker.io/jujusolutions/charm-base
+      - public.ecr.aws/juju/charm-base
     tags:
       - ubuntu-22.04
       - latest
@@ -24,7 +25,8 @@ images:
     dockerfile: Dockerfile-ubuntu
     context: ubuntu-context
     registry_paths:
-      - jujusolutions/charm-base
+      - docker.io/jujusolutions/charm-base
+      - public.ecr.aws/juju/charm-base
     tags:
       - ubuntu-20.04
     platforms:
@@ -43,7 +45,8 @@ images:
     dockerfile: Dockerfile-ubuntu
     context: ubuntu-context
     registry_paths:
-      - jujusolutions/charm-base
+      - docker.io/jujusolutions/charm-base
+      - public.ecr.aws/juju/charm-base
     tags:
       - ubuntu-18.04
     platforms: