Handle exceptions in containers when setting sysctl keys #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javacruft
previously requested changes
Apr 21, 2020
charmhelpers/core/sysctl.py
Outdated
| check_call(call) | ||
| except CalledProcessError as e: | ||
| if is_container(): | ||
| print("Error setting some systcl keys in this container: {}".format(e.output)) |
There was a problem hiding this comment.
Please can we use logging rather than just print here.
javacruft
reviewed
Apr 21, 2020
charmhelpers/core/sysctl.py
Outdated
| check_call(call) | ||
| except CalledProcessError as e: | ||
| if is_container(): | ||
| log("Error setting some systcl keys in this container: {}".format(e.output), |
There was a problem hiding this comment.
typo - sysctl (not systcl) and please can we log this as a warning - its not fatal so it not an error.
ajkavanagh
dismissed
javacruft’s stale review
It looks like the changes have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to focal, when setting some sysctl keys in a container, sysctl returned an exit code of 0. Now, the same error returns a 255. This commit ensures the same behaviour as prior to focal.