[stable/zed] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. Closes LP#2028683
ajkavanagh
changed the title
|
Someone else will have to sign off, but the change looks good to me |
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Aug 22, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Iac8a15c075800dbb44ac498c94c6e917d45614d1
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Aug 22, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I484443c470efe4d3cd89f5b6527576fea7414a03
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Aug 22, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I1ef803d54c7f00e3293891fd3f0b9348c9246ba1
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 7, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. Also pins jsonschema<4.18.0 to avoid rust toolchain (via rpds-py) [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I71fe853755d6f3f05bd7b03006eb55dcafa4cd13
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 7, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ib48b16a23a4b19ed7b54c534cc0c5f05eadeb067
openstack-mirroring
pushed a commit
to openstack/charm-ironic-api
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ic9c479d1076b22419706dfa8fb7940033d13d46e
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I51b9784be407f724515aed655f4325be40057871
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ib64e3b9476c4982aadc6112893799baafba69c77
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Iada0935d58769db112f99ffcb94c1584f88104b1
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I4025a94329951975e0f3ede8f91d687762036e5e
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I4178dc384ef49457fd82649e4ae99850531eb1f2
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I9fe3b8a858eef5e2e6b9be6c6a999ea5388dc933
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ie32bf3d425f0f9fab5737f39c55a497581398d6a
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I44874eaa753761ce3cd27bbf48142c72572fbb04
openstack-mirroring
pushed a commit
to openstack/charm-magnum
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ie2df486c2e65b974574655d714121b8ada1e9289
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Sep 8, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ic6d68dc74e185c493457addae42012190ca8c112
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Sep 13, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I99f45c227ff59d9b9fa77b05c50b114c49d947e2
openstack-mirroring
pushed a commit
to openstack/charm-glance
that referenced
this pull request
Sep 20, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ibdd6b2b8914181c4c7ab88a1a50b2439d6007f93
openstack-mirroring
pushed a commit
to openstack/charm-manila
that referenced
this pull request
Sep 20, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I2594b7b4041a04a0d236daf8f197e60b8c3ee666
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Sep 20, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: I9b8bb0b8a04e3f9b76baee81d9efb8db36f7e2b7
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
…elation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#826 Closes-Bug: #2028683 Change-Id: Ic8e505776c0867b30c272b2a18a5a65a239e4cf4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683