[stable/xena] Ensure get_requests_for_local_unit doesn't fail on incomplete relation (#824) #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplete relation (#824) If the certificates relation has been set from a consuming charm for certificates, but the provider hasn't supplied a certificate, and the request is in the 'legacy' form, then the get_request_for_local_unit() function in cert_utils fails on accessing the (non-existant) 'ca' parameter in the databag. This patch ensures that if the 'ca' key is missing that the processing moves on to the next relation. (cherry-picked from: c8f4720) Closes LP#2028683
|
This change looks good to me. Will need someone else to sign off, of course |
openstack-mirroring
pushed a commit
to openstack/charm-neutron-api
that referenced
this pull request
Sep 7, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Ia55a6fb673ff15db991d706d1217f8e3b3e320e4
openstack-mirroring
pushed a commit
to openstack/charm-keystone
that referenced
this pull request
Sep 7, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Ie73ce7d49c9ce8c4e91cefc6d1d2686f43ca05f9
openstack-mirroring
pushed a commit
to openstack/charm-ironic-api
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: If06ad8d782a47edaa320da8d710211f3ec04e28c
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I1f7368e2851402d67f71f69590d1be6c8ddd25e3
openstack-mirroring
pushed a commit
to openstack/charm-gnocchi
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Icaf60ab6103af1695a1f2aa3efab3546710f50de
openstack-mirroring
pushed a commit
to openstack/charm-heat
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I55c8a57a47857b14152c1231ff2ef532352e453c
openstack-mirroring
pushed a commit
to openstack/charm-nova-cell-controller
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Ic4f9f4e640fefaba9bba486737447e25674359f7
openstack-mirroring
pushed a commit
to openstack/charm-placement
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I21775a9d1a27d43d4310c5b9d4208600d7817ef7
openstack-mirroring
pushed a commit
to openstack/charm-openstack-dashboard
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I9a90bf28b6f5a2b13ddf3b5f172504a4c03fa3fa
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Ia1f610c7653d227e183326075c0b7f3dc906fec5
openstack-mirroring
pushed a commit
to openstack/charm-masakari
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I3ff6b70ac9505da457d6f25899b5d373016b73d0
openstack-mirroring
pushed a commit
to openstack/charm-barbican
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Iee49e080f96788f34c11691b6476d81e1535c215
openstack-mirroring
pushed a commit
to openstack/charm-manila-ganesha
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I4c108ff5c7b3c3b3b12aa4a840428a02e7190b9c
openstack-mirroring
pushed a commit
to openstack/charm-magnum
that referenced
this pull request
Sep 8, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Ia89ef530362ef568063b1dfbbc9996e23331c41c
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
Sep 13, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I9981aad11d9372b29b0095f56d3f04c1471fe4b0
openstack-mirroring
pushed a commit
to openstack/charm-designate
that referenced
this pull request
Sep 13, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: If16f171bf9b3240346380463755de0690fc55547
openstack-mirroring
pushed a commit
to openstack/charm-aodh
that referenced
this pull request
Sep 20, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Ieb16b5600c7bf66931083fbedbd1402dcab26bfe
openstack-mirroring
pushed a commit
to openstack/charm-manila
that referenced
this pull request
Sep 20, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I132dbeeb7e3cf2c6c65110865a9f39ca4b6cc772
openstack-mirroring
pushed a commit
to openstack/charm-ceilometer
that referenced
this pull request
Sep 20, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: I2f13374aaad2c66dda426ad7760d1b6b28b9637a
openstack-mirroring
pushed a commit
to openstack/charm-swift-proxy
that referenced
this pull request
Oct 12, 2023
…relation This is a rebuild/make sync for charms to pickup the fix in charmhelpers to fix any inadvertant accesses of ['ca'] in the relation data before it is available from vault in the certificates relation. Fix in charmhelpers is in [1]. [1] juju/charm-helpers#828 Closes-Bug: #2028683 Change-Id: Id742acf3682b323e2fbef0e1d9526806484db353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the certificates relation has been set from a consuming charm for
certificates, but the provider hasn't supplied a certificate, and the
request is in the 'legacy' form, then the get_request_for_local_unit()
function in cert_utils fails on accessing the (non-existant) 'ca'
parameter in the databag. This patch ensures that if the 'ca' key is
missing that the processing moves on to the next relation.
(cherry-picked from: c8f4720)
Closes LP#2028683