Fix platform check for Debian 12 #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolsen
force-pushed
the
fix-platform-check
branch
from
017f5b6
to
bf729cd
Compare
The osplatform.get_platform() check fails on Debian Bookworm because the output determined by the /etc/os-release file has "Debian GNU/Linux" and the get_platform() check only looks for lowercase debian. Signed-off-by: Billy Olsen <[email protected]>
wolsen
force-pushed
the
fix-platform-check
branch
from
bf729cd
to
274cb37
Compare
hemanthnakkina
approved these changes
Mar 7, 2024
fnordahl
approved these changes
Mar 7, 2024
|
|
||
| class TestPlatform(unittest.TestCase): | ||
|
|
||
| @mock.patch.object(osplatform, "_get_current_platform") |
There was a problem hiding this comment.
nit: there is a BaseTestCase class in tests/utils.py that allows you to do these patches in-line as opposed to using the decorators.
The decorator approach quickly becomes hard to manage with all the positional arguments etc.
There was a problem hiding this comment.
I don't disagree with the nit, but I guess for expediency, let's merge this. I think there's a larger body of work in re-working (or adding separate methods) .patch(...) and .patch_object to also/instead return the mock so that static code analysers in vscode and Neovim+LSP don't complain about the magic members that are added to the object as part of the patching functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The osplatform.get_platform() check fails on Debian Bookworm because the output determined by the /etc/os-release file has "Debian GNU/Linux" and the get_platform() check only looks for lowercase debian.
This is causing tests to fail in the OpenStack Charms CI, as seen here - https://review.opendev.org/c/openstack/charm-keystone-openidc/+/908638