Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip service resume zed - squash #891

Closed
wants to merge 2 commits into from
Closed

Skip service resume zed - squash #891

wants to merge 2 commits into from

Conversation

brianphaley
Copy link

No description provided.

addyess and others added 2 commits April 5, 2024 13:53
@addyess @brianphaley
Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitco…
95a9ddd 
…de (juju#744)

* Issue#743: fetch.ubuntu._run_with_retries raises on unexpected exitcode

* Address `test_check_restart_timestamps` issues in py3.10

* apply appropriate mocks during test_service unit tests

(cherry picked from commit 0f7ca53)
@dosaboy @brianphaley
Skip service_enable if already enabled
0d05a89 
Repeatedly calling service_enable for a service that
is already enabled can lead to unintended consequences.
Some charms frequently call servie_resume which will
call service('enable') and this adds a check to only
do so of the service is not enabled.

Related-Bug: #2058505
(cherry picked from commit a334500)
@brianphaley
Copy link
Author

I'm hoping this runs tests...

@brianphaley
Copy link
Author

Frode went the other way with merging 890, so i'll abandon this and rebase my other change.

@brianphaley brianphaley closed this Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianphaley @addyess @dosaboy