(backport) pin pip<23.1 and setuptools<67 #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to allow PEP-440 non compliance. (backported relevant parts from master branch in juju#653) PEP-440 is more strict about requirement lines. As an example: pytz>dev is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install. The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available. Fixes-Bug: juju#652
ajkavanagh
force-pushed
the
2.8-pin-setuptools-and-pip-for-pep440
branch
from
f3d6e3e
to
910ea5b
Compare
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Nov 29, 2023
Switch to using the latest charm-tools <3.0.0 to fix two build errors: - An error related to 'pytz' fixed in charm-tools 2.8.6: juju/charm-tools#654 - An error related to ruamel.yaml fixed in charm-tools 2.8.8: here: juju/charm-tools#668 Additionally merge bindep.txt to install libpq-dev required for psycopg2-binary as wheels no longer exist for py36. Change-Id: Idc16b84dc3dcdf001c73c7d2fdd57b1d08ebfb23
openstack-mirroring
pushed a commit
to openstack/charm-octavia
that referenced
this pull request
Mar 6, 2024
Switch to using the latest charm-tools <3.0.0 to fix three build errors: - An error related to 'pytz' fixed in charm-tools 2.8.6: juju/charm-tools#654 - An error related to ruamel.yaml fixed in charm-tools 2.8.8: here: juju/charm-tools#668 - An error related to macaroonbakery fixed in charm-tools 2.8.9: juju/charm-tools#671 Additionally merge bindep.txt to install libpq-dev required for psycopg2-binary as wheels no longer exist for py36. Additional fix for ussuri only: - Switch bionic test bundles from vault 1.7/edge to 1.6/edge as the 1.7 channel no longer supports bionic. Change-Id: Idc16b84dc3dcdf001c73c7d2fdd57b1d08ebfb23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow PEP-440 non compliance.
(backported relevant parts from master branch in #653)
PEP-440 is more strict about requirement lines. As an example:
is non-compliant, but is in 5.2.4 of kombu's requirements. This breaks building wheelhouses from source (such as the octavia charm). This patch pins pip and setuptools to the latest versions that will defintely still allow PEP-440 non-compliant packages to install.
The option --upgrade-buildvenv-core-deps can be used to override this and will install the latest versions of pip and setuptools available.
Fixes-Bug: #652
Description of change
Checklist
make test?