Add max attempts to package manager loop #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Oct 24, 2022
jujubot
added a commit
to juju/juju
that referenced
this pull request
Oct 25, 2022
#14811 Pulls in juju/packaging#18 and fixes the issue described there (bootstrap hanging forever). ## QA steps Turn off your internet connection and run ```console $ juju bootstrap lxd c ... Running machine configuration script... ... Err:1 http://archive.ubuntu.com/ubuntu focal/main amd64 msr-tools amd64 1.3-3 Temporary failure resolving 'archive.ubuntu.com' Err:2 http://archive.ubuntu.com/ubuntu focal/main amd64 cpu-checker amd64 0.7-1.1 Temporary failure resolving 'archive.ubuntu.com' E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/m/msr-tools/msr-tools_1.3-3_amd64.deb Temporary failure resolving 'archive.ubuntu.com' E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/c/cpu-checker/cpu-checker_0.7-1.1_amd64.deb Temporary failure resolving 'archive.ubuntu.com' E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing? ... ERROR failed to bootstrap model: subprocess encountered error code 100 ``` ## Bug reference https://bugs.launchpad.net/juju/+bug/1969706 https://bugs.launchpad.net/juju/+bug/1993914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrapping an LXD controller (or adding a new machine), it tries to
apt-get installcertain dependencies. A problem arises when the new machine cannot connect to the apt archive for whatever reason. Theapt-get installis run in an infinite loop, and so the bootstrap hangs forever.This PR adds a max of 5 attempts to the loop, so that the user will get a failure instead of an infinite hang.
QA steps
Copy this branch to local machine and run
Turn off your internet connection and run
Bug reference
https://bugs.launchpad.net/juju/+bug/1969706
https://bugs.launchpad.net/juju/+bug/1993914