-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(jenkins): pin python kubernetes version to fix recent breakage in tests #1106
Conversation
3c02806
to
6b35a92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to plug this quickly if it works.
it would be nice to know what library change made the difference, but that can be handled separately
The failure is when trying to build a wheel for durationpy.
|
Integration tests are failing on this PR, but I'm not sure what the status of these integration tests is. I made a test PR against main (#1107) where the only change is adding my name to Six failures are in common across both PRs (both runs):
Unique to this PR (one of the two runs only):
Unique to dummy PR [#1107] (both runs):
I'm going to rerun the integration tests and see if they have the same results. |
See issue #1108 for a table of test failures. |
6b35a92
to
1fe4cfb
Compare
/merge |
Description
Pin python kubernetes version to fix recent breakage in jenkins tests.
The latest update to the python kubernetes library (v31, 3 days ago) breaks the Jenkins
github-check-merge-juju-python-libjuju
test due to failure to build a new dependency (durationpy).I thought this might be the fix for issue #1088, but that's been open since August 9. Should we switch to stricter dependency versioning across the board here to avoid breakages of this nature? In setup.py, 4 dependencies now specify both minimum and maximum versions, 5 only specify a minimum, and 2 have no version specification. In tox.ini, only 1 dependency (kubernetes) specifies a (maximum) version. tox.ini should probably have the same version constraints as setup.py.
QA Steps
All tests pass, except for integration tests, which are flaky (see issue #1108).