Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-4012] Allow runners to stop based on an error #28

Merged
merged 3 commits into from
Jun 26, 2023
Merged

[JUJU-4012] Allow runners to stop based on an error #28

merged 3 commits into from
Jun 26, 2023

Commits on Jun 21, 2023

  1. Allow runners to stop based on an error 

    The following allows a runner to be stopped based on an error
message. This makes it much more flexible in the phase of workers
stopping based on an error, yet we don't want them to restart for
some reason.
    @SimonRichardson
    SimonRichardson committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1f375fb View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. Ensure worker isn't found to ensure it was never started

    @SimonRichardson
    SimonRichardson committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    fbc3e54 View commit details
    Browse the repository at this point in the history

  2. Rename to ShouldRestart 

    It's clearer than the previous name. By indicating what will happen
if you return false it prevents a restart happening.
    @SimonRichardson
    SimonRichardson committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    5e41d7e View commit details
    Browse the repository at this point in the history