Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency context.Context #31

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Commits on Sep 13, 2023

  1. Dependency context.Context introduction

    The following reworks the dependency engine to bring in a real
    context.Context. The fallout of this means that we decouple the
    concept of cancelation and where you get the dependency from. In
    doing so, context has become snapshot. The original comments
    around this type just state that it is a snapshot, so we might as
    well just call it that.
    The dependency Context becomes split. Removing the cross cutting
    concerns. The aborting of a worker in the start now becomes
    context.Context and the retrival of a dependency is now a Container.
    Currently we're just creating a adhoc context.Context, but in the
    next commit, we'll tie this to the tomb directly, ensuring that upon
    destruction of the engine, all manifolds will be killed.
    SimonRichardson committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ba2a865 View commit details
    Browse the repository at this point in the history
  2. Scoped context

    The context creation is now tied to the lifecycle of the tomb. Doing
    this ensures that when the engine is killed, then the context is also
    killed. It worth noting that cancel is idempotent so, calling it multiple
    times does nothing. As the main loop on tomb death is also attempting
    to cancel the context of the snapshot worker, it essentially becomes a
    no-op.
    SimonRichardson committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    baa9f2b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Rename Container to Getter

    Renaming Container (DI) to Getter to prevent any confusion over what
    a container is in this context.
    SimonRichardson committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    6b9c0d4 View commit details
    Browse the repository at this point in the history
  2. Update version - v4

    This is a breaking change, so we should bump from v3 to v4.
    SimonRichardson committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    0594441 View commit details
    Browse the repository at this point in the history