Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): cozo queries for tasks #352

Merged
merged 7 commits into from
Jun 6, 2024
Merged

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented May 30, 2024

Signed-off-by: Diwank Tomer [email protected]


🚀 This description was created by Ellipsis for commit 3c241b2

Summary:

This PR updates task and execution querying functions to use agent_id, adds tests, and modifies routers, but retains developer_id in execution queries, contradicting its goal.

Key points:

  • Updated create_task_query, get_task_query, and list_tasks_query to use agent_id.
  • Introduced new execution model functions and updated routers to use these functions.
  • Retained developer_id in execution queries, contradicting the PR's goal.
  • Added tests for new querying functions.
  • Included new files for execution queries.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7cd1c32 in 1 minute and 20 seconds

More details
  • Looked at 91 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_OJsXWvaq97rGsnCS


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5406a2b in 2 minutes and 1 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/routers/tasks/routers.py:66
  • Draft comment:
    The PR description states that developer_id should be replaced with agent_id. Please update the parameter accordingly to align with the new entity identification strategy.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_z8lrZERTUDk200lT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 05ec664 in 1 minute and 9 seconds

More details
  • Looked at 83 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_nU2hpv1ypRPA138O


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on e630a55 in 1 minute and 59 seconds

More details
  • Looked at 94 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_ckAg0lSO0vtIW8Qx


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 6f9dab5 in 5 minutes and 23 seconds

More details
  • Looked at 2179 lines of code in 23 files
  • Skipped 2 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/models/execution/create_execution.py:6
  • Draft comment:
    The function signature still includes developer_id which contradicts the PR's goal of using agent_id. This should be updated to use agent_id to align with the rest of the changes in the PR.
  • Reason this comment was not posted:
    Confidence of 30% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_fqRQIckG58zXeA4V


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on c39ca0a in 3 minutes and 38 seconds

More details
  • Looked at 196 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. agents-api/agents_api/models/task/get_task.py:13
  • Draft comment:
    The developer_id parameter is not used in the get_task_query function and contradicts the PR's goal of using agent_id. Consider removing this parameter if it's not needed.
    agent_id: UUID, task_id: UUID
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.
2. agents-api/agents_api/models/task/list_tasks.py:7
  • Draft comment:
    The developer_id parameter is not used in the list_tasks_query function and contradicts the PR's goal of using agent_id. Consider removing this parameter if it's not needed.
agent_id: UUID,
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_jVHw0GBZLCDVTu5g


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr changed the title wip(agents-api): cozo queries for tasks feat(agents-api): cozo queries for tasks Jun 6, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3c241b2 in 1 minute and 13 seconds

More details
  • Looked at 575 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/models/execution/create_execution.py:12
  • Draft comment:
    The function still uses developer_id which contradicts the PR's goal of using agent_id. This inconsistency should be addressed across all execution model functions.

This comment applies to all execution model functions where developer_id is still used.

  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_YXaeeFhaNaSCJqXO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr merged commit 639e80e into dev-tasks Jun 6, 2024
6 of 9 checks passed
@creatorrr creatorrr deleted the f/tasks-cozo-queries branch June 6, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants