Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle prompt too big error #401

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

whiterabbit1983
Copy link
Contributor

@whiterabbit1983 whiterabbit1983 commented Jun 24, 2024

🚀 This description was created by Ellipsis for commit 92c888a

Summary:

Added an exception handler for PromptTooBigError in agents-api/agents_api/web.py that returns a 400 status code and an error message.

Key points:

  • Added PromptTooBigError import in agents-api/agents_api/web.py.
  • Registered a new exception handler for PromptTooBigError in agents-api/agents_api/web.py.
  • The handler returns a 400 status code and an error message when PromptTooBigError is raised.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 92c888a in 43 seconds

More details
  • Looked at 37 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/web.py:97
  • Draft comment:
    The function name validation_error_handler is misleading for handling RPCError related to job issues. Consider renaming it to reflect its actual purpose, such as rpc_error_handler.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_1DTytBw64CjTra73


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@whiterabbit1983 whiterabbit1983 merged commit e8090dd into dev Jun 25, 2024
6 of 9 checks passed
@whiterabbit1983 whiterabbit1983 deleted the x/prompt-too-big-handler branch June 25, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant