creatorrr/f add missing tests #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* **`test_agent_queries.py`** - Add test for `create_or_update_agent` query - Add test for `patch_agent` query * **`test_docs_queries.py`** - Add test for `embed_snippets` query * **`test_entry_queries.py`** - Add test for `delete_entries` query * **`test_execution_queries.py`** - Add test for `create_execution_transition` query * **`test_session_queries.py`** - Add test for `create_or_update_session` query * **`test_task_queries.py`** - Add test for `create_or_update_task` query * **`test_tool_queries.py`** - Add test for `patch_tool` query * **`test_user_queries.py`** - Add test for `create_or_update_user` query
Signed-off-by: Diwank Tomer <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to d305468 in 32 seconds
More details
- Looked at
1029lines of code in23files - Skipped
3files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_C3jSkhphbCU155te
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -37,7 +37,9 @@ | |||
| TypeError: partialclass(HTTPException, status_code=400), | |||
| } | |||
| ) | |||
| @wrap_in_class(Transition, transform=lambda d: {"id": d["transition_id"], **d}) | |||
| @wrap_in_class( | |||
There was a problem hiding this comment.
The one=True parameter in the @wrap_in_class decorator is used incorrectly here. It should be set to False or removed because the function can potentially handle multiple transitions, not just one. This could lead to incorrect assumptions about the return type when the function is used elsewhere in the code.
Suggested change
| @wrap_in_class( | |
| Transition, transform=lambda d: {"id": d["transition_id"], **d}, one=False |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agents-apiSummary:
This PR adds missing tests for
agents-apiqueries, fixes existing tests, and updates TypeScript SDK models and schemas to align with API changes.Key points:
agents-apiqueries inagents-api/tests.agents-api/tests.FunctionDefmodel inagents-api/agents_api/autogen/Tools.py.create_or_update_agentfunction inagents-api/agents_api/models/agent/create_or_update_agent.py.create_execution_transitionfunction inagents-api/agents_api/models/execution/create_execution_transition.py.patch_toolandupdate_toolfunctions inagents-api/agents_api/models/tools.sdks/ts/src/apito reflect API changes.Generated with ❤️ by ellipsis.dev