Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agents-api): Add some workflow tests #456

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented Aug 14, 2024

Signed-off-by: Diwank Tomer [email protected]


🚀 This description was created by Ellipsis for commit 3a38e70

Summary:

Added workflow tests and modified transition handling to update execution status in the agents API.

Key points:

  • Removed UpdateExecutionRequest import from agents-api/agents_api/activities/task_steps/__init__.py.
  • Replaced print with activity.heartbeat in transition_step function in agents-api/agents_api/activities/task_steps/__init__.py.
  • Modified create_execution_transition in agents-api/agents_api/models/execution/create_execution_transition.py to update execution status.
  • Added transition_to_execution_status mapping in agents-api/agents_api/models/execution/create_execution_transition.py.
  • Changed task to task: TaskSpecDef in ExecutionInput class in agents-api/agents_api/common/protocol/tasks.py.
  • Added tests for execution transitions and task routes in agents-api/tests/test_execution_queries.py and agents-api/tests/test_task_routes.py.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 3a38e70 in 30 seconds

More details
  • Looked at 290 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_yMjqgB0mGFaj7seX


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -25,9 +24,6 @@
from ...models.execution.create_execution_transition import (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of update_execution_query suggests refactoring, but UpdateExecutionRequest is still imported and used only in create_execution_transition. Consider refactoring or clarifying the usage to prevent confusion or dead code.

@whiterabbit1983 whiterabbit1983 merged commit 9e4b707 into dev-tasks-disable-routes Aug 14, 2024
2 of 5 checks passed
@whiterabbit1983 whiterabbit1983 deleted the f/workflow-tests branch August 14, 2024 17:54
@creatorrr creatorrr restored the f/workflow-tests branch August 14, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants