Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build script to handle macOS sed correctly #8

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

IanButterworth
Copy link
Member

Otherwise on MacOS it fails with sed: 1: ".gitignore": invalid command code .

Copy link
Member

@DilumAluthge DilumAluthge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also just rewrite the entire script in Julia (instead of Bash).

build-release.sh Outdated Show resolved Hide resolved
Co-authored-by: Dilum Aluthge <[email protected]>
@IanButterworth
Copy link
Member Author

I can test and merge this, update the subproject commit on the action etc. during the next setup-julia release

@DilumAluthge DilumAluthge changed the title build fixes Fix the build script to handle macOS sed correctly Jun 20, 2024
@DilumAluthge
Copy link
Member

Bump @IanButterworth Can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants