-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links open inside Prospect Mail window, instead of a browser #240
Comments
I see the same. Using the navigation buttons on the side of my mouse does work to return to the mailbox, but no other way is available as far as I can tell. |
Did someone find a way to fix this? |
CORRECTION:
|
Ok, so I just reinstalled the SnapCraft version, and changed these lines:
to:
I had to quit and restart Prospect Mail as reload didn't seem to change this behavior. Keira |
I've tried solution from @keirak420 but it does not seem to work. From js logic all is fine, and exactly the branch that should open link in browser is executed, but in fact page is still opened inside prospect's window. Here is the log that I can see, hope it can help identify issue. Maybe the root cause is ibus connectivity issue as I see some warning about it?
|
Any update on this? |
I had to switch to Freelook because of this and Freelook doesn't have this issue. |
Just confirming that I also see the issue, but started seeing it maybe a month ago or so. Not sure why it manifested later than the rest of you. Thanks for the posts. I will try some of the configurations suggested here. Update: I experimented with the proposed setting and noted that having just Cheers |
Seeing the same problem, the logs shows "opening in browser" but the link is openend inside Prospect Mail :(
|
This started happening to me because my company enabled some outlook I think the regex logic for determining when to open links in a new window needs support for exclusion patterns.
prospect-mail/src/controller/mail-window-controller.js Lines 243 to 261 in 04e96a1
|
I am also affected by this. Whenever I click on a link, it opens within Prospect Mail. I am then unable to return to Prospect Mail. My best option is then to close Prospect Mail, and click "Quit" via right-click on the unwanted Prospect Mail icon at the top bar of Gnome (Ubuntu). Is there perhaps a keyboard shortcut for "Back" (previous page), which might already be available? |
Best work around I have found is to alt+F4 the prospect-mail window and relaunch the program. This keeps prospect-mail running in the background but seems to reset the session and brings you back to mail. |
Thanks. I tried that, but bizarrely it seems I have to perform those actions twice before it works (using either ALT-F4 or the X at the top-right). With the method I mentioned, I have now discovered that only the second part is required: right-click on the (otherwise) unwanted Prospect Mail icon at the top bar of Gnome (Ubuntu), and select: Quit. That both closes the window and resets the session. |
@pkeir Right click on the top bar icon does not work for my. In my case right click on the icon opens a context menu and enable/disable the checkbox "Window Frame" reloads the prospect mail session and i can access my mails again |
Nice. This does work for me, though I find on the menu that pops up from the top bar icon, the choice is The only disadvantage is that with |
Links seem now to be opening correctly in the browser for me. |
I wonder what the meaning of this setting is, it makes no sense to me. In the code, urlsInternal goes into the "deeplinkUrls" variable. "urlsExternal" goes to the "outlookUrls" variable. outlookUrls are always opened within the application's main window. For deeplinkUrls, the "default bahaviour" is used (I guess either the main window or a new application window). I modified the code a bit locally to allow to force that some URLs are opened in an external browser. This way I can force "safelink.html" to be opened external although it matches the other domains which solves this issue for me. I will provide a PR for testing. |
I spoke too soon: YouTube, Github and OneDrive links (at least) are once again opening within Prospect Mail. |
Me too (on Ubuntu 20.04). The problem with the "click on top bar icon, quit and restart" is that then I lose my location in the middle of the hundreds of emails I'm trying to deal with. People suggested changing something in By the way, to confirm that this is a work account and now when I click on a link I get a "Verifying link..." page for a second or two, with "Powered by Office 365 Advanced Threat Protection" at the bottom. Right now to work around this I've resorted to reading emails in a browser window, which is randomly awful for other reasons (I've had issues with emails being spontaneously deleted, for example; this doesn't happen for me with Prospect Mail). |
can you give my PR #262 a try to check if it solves the issue for you? |
I'm afraid that I'm just using Prospect Mail via some package manager and am in no position to compile it myself. Icon click -> settings -> settings file just opens a random folder on my system called .config with e.g. some md5sum files in and a few directories. Update: the directory is Final update: I changed the contents of this file to {
"urlMainWindow":"https://outlook.live.com/mail",
"urlsInternal":["outlook.com", "live.com"],
"urlsExternal":["outlook.com", "live.com"]
} and this seems to have fixed the problem for me (I had to log in again). Thanks to the people who posted in this thread! |
Any way to force the links to be opened in Firefox? |
Oh this is a great question: I've noticed that right now in my set-up the links are being opened in a new window but with no browser buttons (so e.g. you can't go back if you click on a link) |
The workaround needs to be changed to {
"urlMainWindow":"https://outlook.office.com/mail/",
"urlsInternal":["outlook.com", "live.com"],
"urlsExternal":["outlook.com", "live.com"]
} now |
I tried the solution above. I edited It's certainly easier then to recover, but this is still not a proper fix. |
Yeah, there is another fix in a fork somewhere, but I was too lazy to build it myself. Here: #262 Since the developer has abandoned this project, someone should maybe build it or create an AUR package |
The problem is in the sniped code by paulquevedojdrf, but understanding the code, you only need to modify the property "urlsExternal" in the settings.json file with a customer random array string, to overwrite the default value. My in case I add this value for "urlsExternal": File settings.json Close and reopen prospect mail, and now all the links are open in a new web browser window. |
This opens the links in a new window of some sort but I still don't get the browser navigation buttons such as a "back" button, and I'm not logged into things like github if I click on a github link. |
Still doesn't work with latest main build for me, links still open inside prospect client built and installed using snap. Also changing settings.json does not seem to have effect on this, either by setting urlsExternal to a weird value or setting the other suggested values. |
Please try again @justinvson-pd . You could use the beta channel of snap with version 0.5-beta1 |
It should work. I run a build of that PR since I created it and had no single external link opened in the mail window. |
There has been some changes apparently in Outlook Web, as Prospect Mail have not changed.
This week, I started to notice that when ever I try to click any link inside the email, it opens up inside Prospect Mail window. And because there is no navigation buttons, I cannot anymore get back to my email.
The text was updated successfully, but these errors were encountered: