Fix libblastrampoline with Ipopt_jll #163

odow · 2023-03-22T04:16:48Z

odow · 2023-03-22T04:24:33Z

As a note to my future self, here's a drop in replacement for Ipopt_jll.amplexe that we could add to Ipopt:

import OpenBLAS32_jll
import Ipopt_jll

function amplexe(f)
    lbt_default_libs = get(ENV, "LBT_DEFAULT_LIBS", nothing)
    if lbt_default_libs === nothing
        ENV["LBT_DEFAULT_LIBS"] = OpenBLAS32_jll.libopenblas
    end
    ret = Ipopt_jll.amplexe(f)
    if lbt_default_libs === nothing
        delete!(ENV, "LBT_DEFAULT_LIBS")
    else
        ENV["LBT_DEFAULT_LIBS"] = lbt_default_libs
    end
    return ret
end

src/AmplNLWriter.jl

odow · 2023-03-22T04:40:18Z

Aaaaand. Windows is the odd duck

https://github.com/jump-dev/AmplNLWriter.jl/actions/runs/4486368238/jobs/7888794896?pr=163

giordano · 2023-03-22T10:42:56Z

As a note to my future self, here's a drop in replacement for Ipopt_jll.amplexe that we could add to Ipopt:

As a general remark, I'd warn you against manipulating ENV directly: that's an unsafe global state, should something fail while you're editing it you can be left in a nasty state. Instead, use addenv, which also affects only sub-processes.

src/AmplNLWriter.jl

odow · 2023-03-22T22:19:52Z

As a general remark, I'd warn you against manipulating ENV directly

Sure. I don't think we'd advise using it in anything critical. (The code here uses addenv.)

It's more for the occasions when I want to run the binary quickly in the REPL to test something.

odow · 2023-03-22T23:20:30Z

So all we get is an unhelpful could not spawn setenv('C:\\Users\\runneradmin\\.julia\\artifacts\\774ef6a9c59cbea84ec6a86bf6d7a2dc39eff2e6\\bin\\ipopt.exe` error.

The complication is that we use openblas on Windows:
https://github.com/JuliaPackaging/Yggdrasil/blob/d3cf664e736225391b0e0dbffbec28ce20688434/C/Coin-OR/Ipopt/build_tarballs.jl#L28-L32
and LBT on others
https://github.com/JuliaPackaging/Yggdrasil/blob/d3cf664e736225391b0e0dbffbec28ce20688434/C/Coin-OR/Ipopt/build_tarballs.jl#L68-L69

But it seems like the original reason is now fixed, JuliaLinearAlgebra/libblastrampoline#89, JuliaLang/julia#47638, so we could try rebuilding Ipopt.

odow · 2023-03-22T23:24:34Z

x-ref: JuliaPackaging/Yggdrasil#6441

src/AmplNLWriter.jl

odow · 2023-03-23T01:43:09Z

@staticfloat any ideas? Our ipopt.exe binary uses OpenBLAS32_jll directly and doesn't use LBT. I just get a 'could not spawn' error: https://github.com/jump-dev/AmplNLWriter.jl/actions/runs/4495954495/jobs/7910133289?pr=163#step:6:173

MOI.get(model, MOI.RawStatusString()) = "Error calling the solver. Failed with: Base.IOError(\"could not spawn `'C:\\\\Users\\\\runneradmin\\\\.julia\\\\artifacts\\\\774ef6a9c59cbea84ec6a86bf6d7a2dc39eff2e6\\\\bin\\\\ipopt.exe' 'C:\\\\Users\\\\RUNNER~1\\\\AppData\\\\Local\\\\Temp\\\\jl_eXBXKp\\\\model.nl' -AMPL 'option_file_name=D:\\\\a\\\\AmplNLWriter.jl\\\\AmplNLWriter.jl\\\\test\\\\ipopt.opt' print_level=1`: unknown error (UNKNOWN)\", -4094)"

I don't have a windows machine, so I'm a but out of luck.

We know that the LibraryProduct works fine on Windows, because that's what https://github.com/jump-dev/Ipopt.jl is. This is just a problem with the ExecutableProduct.

staticfloat · 2023-03-23T04:53:39Z

I don't really know, sorry. It's weird to me that there are so many backslashes.... is there some kind of path escaping going on?

amontoison · 2023-03-27T05:19:21Z

@odow I recompiled MUMPS with LBT for Julia >= 1.9.
I will do the same thing with Ipopt.

I propose to not support anymore the artifacts with partial support of LBT when Julia 1.9 will be released.

odow · 2023-03-27T23:16:35Z

Okay. I'll wait for that release before spending more time trying to debug this

odow · 2023-03-27T23:17:12Z

is there some kind of path escaping going on?

I tried removing some of the escapes. But I think it's just a printing artifact of how we're catching the exception, storing it as a string, and then printing it.

odow · 2023-03-27T23:36:38Z

It can't even spawn $exe -v, so something is massively wrong.

amontoison · 2023-03-31T06:34:08Z

@odow For Windows we don't need to modify something because I precompiled the last Ipopt_jll with OpenBLAS32_jll. If the old version of Ipopt_jll 300.1400.400 is working, I don't understand why something changed with the last artifact.
We only need to provide additional arguments for LBT when !Sys.windows().

odow · 2023-05-10T02:05:14Z

Let's see how JuliaPackaging/Yggdrasil#6734 goes.

odow · 2023-05-10T02:26:38Z

@amontoison is used the new version:

but what are we missing?

It was compiled with https://buildkite.com/julialang/yggdrasil/builds/2943#01880319-dbcd-47ac-bf17-436ae373a5d4

but it used OpenBLAS 0.3.21. Could that be a problem?

It's using MUMPS 500.500.101, which is JuliaPackaging/Yggdrasil#5599, which uses OpenBLAS on Windows.

amontoison · 2023-05-10T02:44:18Z

@odow
I found this message in the logs: https://buildkite.com/julialang/yggdrasil/builds/2943#01880319-dbcd-47ac-bf17-436ae373a5d4/638-1459

odow · 2023-05-10T02:49:05Z

Hoorah. Only. What does that mean.

amontoison · 2023-05-10T03:09:27Z

@odow
I recompiled the old release 3.14.4 on Windows (with the last release of OpenBLAS32), can you test with my fork https://github.com/amontoison/Ipopt_jll.jl ?
The version of the artifact is 300.1400.1066 (3.14.4 + 666 👿)

amontoison · 2023-05-10T03:43:33Z

Can you add a println(Base.BinaryPlatforms.host_triplet()) to check the platform of the Windows builds?
It seems that Ipopt 3.14.4 is not working with the updated dependencies.
The culprit is OpenBLAS32 or MUMPS_seq.

odow · 2023-05-10T03:57:53Z

x86_64-w64-mingw32-libgfortran5-cxx11-julia_version+1.9.0

It pulled in Julia v1.9.0?

odow · 2023-05-10T04:19:20Z

test/MOI_wrapper.jl

+    end
+    path() do exe
+        run(`$exe -v`)
+    end


@amontoison I think you need some tests like this.

In the normal tests, we can't open the executable, but we trap the error and return OTHER_ERROR to MOI so it looks as if the binary didn't find a solution, but really it crashed.

odow · 2023-06-07T21:43:46Z

@amontoison the windows executable is still a problem

amontoison · 2023-06-07T23:17:38Z

I don't know where is the issue Oscar. :(
I should try to compile with an older CompilerSupportLibraries_jll.

giordano · 2023-06-07T23:25:42Z

That doesn't make much sense since we do dynamic linking. But using an older gcc+binutils can make a difference

amontoison · 2023-06-07T23:44:45Z

That doesn't make much sense since we do dynamic linking.

Indeed, it is not relevant.

But using an older gcc+binutils can make a difference

The issue is that ipopt uses libgfortran and we can't use a compiler older than GCC8 if we link with libgfortran5.
What I don't understand is that is that we now have an error if we recompile the working version 300.1400.400 with exactly the same options.

amontoison · 2023-11-12T19:55:21Z

@odow
https://buildkite.com/julialang/yggdrasil/builds/6557#018bc4c1-67d1-4f79-87e8-23858206da1a/614-1276

amontoison · 2024-02-20T05:33:44Z

@odow Can you try the last Ipopt_jll.jl ?

test/MINLPTests/Project.toml

Project.toml

odow · 2024-02-20T21:59:44Z

Fixed at last

odow · 2024-02-20T22:26:33Z

amontoison · 2024-02-20T22:35:00Z

Amazing @odow 🎉 🎉
What was the issue finally?

odow · 2024-02-20T22:36:23Z

No idea. But you must have done something. Perhaps the openmp stuff? Or just general Julia/lbt improvements.

staticfloat reviewed Mar 22, 2023

View reviewed changes

src/AmplNLWriter.jl Outdated Show resolved Hide resolved

odow commented Mar 22, 2023

View reviewed changes

src/AmplNLWriter.jl Outdated Show resolved Hide resolved

odow commented Mar 22, 2023

View reviewed changes

src/AmplNLWriter.jl Outdated Show resolved Hide resolved

odow commented Mar 22, 2023

View reviewed changes

src/AmplNLWriter.jl Outdated Show resolved Hide resolved

Vaibhavdixit02 mentioned this pull request Mar 31, 2023

Add julia compat bounds to Ipopt_jll JuliaRegistries/General#80632

Closed

odow closed this May 10, 2023

odow reopened this May 10, 2023

odow commented May 10, 2023

View reviewed changes

odow mentioned this pull request Nov 12, 2023

[Ipopt] Upgrade to version 3.14.3 JuliaPackaging/Yggdrasil#7663

Merged

odow commented Feb 20, 2024

View reviewed changes

test/MINLPTests/Project.toml Outdated Show resolved Hide resolved

odow commented Feb 20, 2024

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

Fix libblastrampoline with Ipopt_jll

be6b339

odow force-pushed the od/fix-blas branch from 02ba9f3 to be6b339 Compare February 20, 2024 21:20

odow added 3 commits February 21, 2024 10:30

Update

9ddfcf7

Update

dbfad7a

Update

e0bcc42

odow mentioned this pull request Feb 20, 2024

Debug ipopt.exe on Windows #170

Closed

odow merged commit 732090e into master Feb 20, 2024
13 checks passed

odow deleted the od/fix-blas branch February 20, 2024 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix libblastrampoline with Ipopt_jll #163

Fix libblastrampoline with Ipopt_jll #163

odow commented Mar 22, 2023

odow commented Mar 22, 2023

odow commented Mar 22, 2023

giordano commented Mar 22, 2023

odow commented Mar 22, 2023

odow commented Mar 22, 2023 •

edited

Loading

odow commented Mar 22, 2023

odow commented Mar 23, 2023

staticfloat commented Mar 23, 2023

amontoison commented Mar 27, 2023

odow commented Mar 27, 2023

odow commented Mar 27, 2023

odow commented Mar 27, 2023

amontoison commented Mar 31, 2023 •

edited

Loading

odow commented May 10, 2023

odow commented May 10, 2023

amontoison commented May 10, 2023

odow commented May 10, 2023

amontoison commented May 10, 2023 •

edited

Loading

amontoison commented May 10, 2023 •

edited

Loading

odow commented May 10, 2023

odow May 10, 2023

odow commented Jun 7, 2023

amontoison commented Jun 7, 2023

giordano commented Jun 7, 2023

amontoison commented Jun 7, 2023 •

edited

Loading

amontoison commented Nov 12, 2023

amontoison commented Feb 20, 2024

odow commented Feb 20, 2024

odow commented Feb 20, 2024

amontoison commented Feb 20, 2024

odow commented Feb 20, 2024

Fix libblastrampoline with Ipopt_jll #163

Fix libblastrampoline with Ipopt_jll #163

Conversation

odow commented Mar 22, 2023

odow commented Mar 22, 2023

odow commented Mar 22, 2023

giordano commented Mar 22, 2023

odow commented Mar 22, 2023

odow commented Mar 22, 2023 • edited Loading

odow commented Mar 22, 2023

odow commented Mar 23, 2023

staticfloat commented Mar 23, 2023

amontoison commented Mar 27, 2023

odow commented Mar 27, 2023

odow commented Mar 27, 2023

odow commented Mar 27, 2023

amontoison commented Mar 31, 2023 • edited Loading

odow commented May 10, 2023

odow commented May 10, 2023

amontoison commented May 10, 2023

odow commented May 10, 2023

amontoison commented May 10, 2023 • edited Loading

amontoison commented May 10, 2023 • edited Loading

odow commented May 10, 2023

odow May 10, 2023

Choose a reason for hiding this comment

odow commented Jun 7, 2023

amontoison commented Jun 7, 2023

giordano commented Jun 7, 2023

amontoison commented Jun 7, 2023 • edited Loading

amontoison commented Nov 12, 2023

amontoison commented Feb 20, 2024

odow commented Feb 20, 2024

odow commented Feb 20, 2024

amontoison commented Feb 20, 2024

odow commented Feb 20, 2024

odow commented Mar 22, 2023 •

edited

Loading

amontoison commented Mar 31, 2023 •

edited

Loading

amontoison commented May 10, 2023 •

edited

Loading

amontoison commented May 10, 2023 •

edited

Loading

amontoison commented Jun 7, 2023 •

edited

Loading