Fix for windows and v0.6 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why does the call to esc need to be version conditional at all? |
|
I just copied jump-dev/Xpress.jl@6fe4193 |
|
Without the conditional (i.e. just the v0.6 branch) I get julia> using CPLEX
INFO: Recompiling stale cache file C:\Users\odow003\.julia\lib\v0.5\CPLEX.ji for
module CPLEX.
ERROR: LoadError: LoadError: syntax: ccall argument types must be a tuple; try "
(T,)"
in include_from_node1(::String) at .\loading.jl:488 (repeats 2 times)
in macro expansion; at .\none:2 [inlined]
in anonymous at .\<missing>:?
in eval(::Module, ::Any) at .\boot.jl:234
in process_options(::Base.JLOptions) at .\client.jl:239
in _start() at .\client.jl:318
while loading C:\Users\odow003\.julia\v0.5\CPLEX\src\cpx_env.jl, in expression s
tarting on line 1
while loading C:\Users\odow003\.julia\v0.5\CPLEX\src\CPLEX.jl, in expression sta
rting on line 85
ERROR: Failed to precompile CPLEX to C:\Users\odow003\.julia\lib\v0.5\CPLEX.ji.
in compilecache(::String) at .\loading.jl:593
in require(::Symbol) at .\loading.jl:393 |
|
@mlubin do I remember you filing an issue about this? Wondering if it was JuliaLang/julia#15850 or JuliaLang/julia#18754 that caused the issue... |
|
I can't find any issue I filed about this. |
|
This might be the discussion you were remembering: https://discourse.julialang.org/t/macro-that-uses-ccall-in-julia-0-6-0/2639 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes tests on Windows Julia-0.5 and Julia-0.6