A thorough modernization of the MOI wrapper #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note the failure on 0.7 (it's ok to drop 0.7). |
|
The diff is hard to review in detail, but there were lots of bugs/unimplemented features like constants in the objective function. If this passes CI then it is passing every relevant MILP test in MOI so that seems pretty safe... Yay for a strong battery of tests. |
|
I'll leave dropping 0.7 for another PR. |
|
Tagged a new release as well. |
|
Thanks guys, I took my time to read the code and indeed the code is better now. |
|
@vitornesello no worries! Thanks for already completing the bulk of the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes all outstanding MOI related issues and gets Cbc in a nice shape for JuMP 0.19 release.
It was easier to just tidy up the wrapper in one shot that have many PRs sitting in CI.
Closes #107
Closes #106
Closes #104
Closes #102Closes #96
Closes #81
Closes #79