BinaryBuilder and BinaryProvider builds #75
Conversation
updating
Update bb version
REQUIRE
Outdated
| @@ -1,5 +1,4 @@ | |||
| julia 0.6 | |||
| BinDeps | |||
| @osx Homebrew | |||
| BinaryProvider | |||
There was a problem hiding this comment.
Should this have a lower bound of 0.3 as per the comment in deps/build.jl?
deps/build.jl
Outdated
| provides(Homebrew.HB, "staticfloat/juliadeps/glpk461", glpkdep, os = :Darwin) | ||
| using BinaryProvider # requires BinaryProvider 0.3.0 or later | ||
|
|
||
| evalfile("build_GMP.v6.1.2.jl") |
There was a problem hiding this comment.
evalfile is unusual, why not include?
There was a problem hiding this comment.
Not sure, this is just how Pkg calls the build files in v0.6 https://github.com/JuliaLang/julia/blob/9d11f62bcb124327831206089967f93020e84200/base/pkg/entry.jl#L601
Note that this may be a faster way:
https://github.com/JuliaGeo/GDAL.jl/blob/0c82e14a7ff406ad22728a7d3f3b5ccf140a5c21/deps/build.jl#L11-L16
deps/build.jl
Outdated
| provides(Homebrew.HB, "staticfloat/juliadeps/glpk461", glpkdep, os = :Darwin) | ||
| using BinaryProvider # requires BinaryProvider 0.3.0 or later | ||
|
|
||
| evalfile("build_GMP.v6.1.2.jl") |
There was a problem hiding this comment.
I don't know how BB works, but why is a build file needed for GMP given that GMP is just a dependency of GLPK and isn't referenced by the julia code?
There was a problem hiding this comment.
So this is a "binary" dependency. Basically travis cannot compile monolithic builds so we need pre-compiler libraries like GMP. However, the you need to make sure those are also installed. In this case there is no GMP "julia package" on which GLPK could be dependent to force the install of the binaries. Resolving this is part of the BB roadmap, but it will probably use Pkg3 so we need a "hack" like this for 0.6. This gets trickier for COIN-OR solvers and it could lead to multiple versions of a library being loaded, but according to JuliaGeo/GDAL.jl/pull/52 it should be ok. Definitely worth discussing before resolving. For more details see the discussions in
https://docs.google.com/document/d/1PFw82MMGv3HEth4l1lGKEU1n71zIyEZyrIh4xJli8ck/edit?usp=sharing
deps/build.jl
Outdated
| # Download and install binaries | ||
| install(url, tarball_hash; prefix=prefix, force=true, verbose=verbose) | ||
| end | ||
| elseif unsatisfied |
There was a problem hiding this comment.
This logic is a bit different from what's in Ipopt (https://github.com/JuliaOpt/Ipopt.jl/blob/a8b12c4dfe7a9d329050bbc416c7bbe2a4722358/deps/build.jl#L37). Does it allow for local installs of GLPK outside BB?
There was a problem hiding this comment.
It now allows for local installs with something like ./configure --prefix=$HOME/.julia/v0.6/GLPK/deps/usr. If it finds this it will not download any of the BB tarballs (including the GMP dependency)
There was a problem hiding this comment.
Ok, so we do need the
if haskey(download_info, platform_key())
url, tarball_hash = download_info[platform_key()]
if unsatisfied || !isinstalled(url, tarball_hash; prefix=prefix) logic to make sure binaries are installed. The logic is: If there is a tarball get its info (if haskey, download_info) and check if it has been downloaded, all the binaries it should contain are there and are not older than the downloaded file (isinstalled). If the user overwrote the binaries from a tarball those remain until there is a new tarball.
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 52.17% 52.17%
=======================================
Files 4 4
Lines 1612 1612
=======================================
Hits 841 841
Misses 771 771Continue to review full report at Codecov.
|
| if Compat.Sys.isapple() | ||
| using Homebrew | ||
| provides(Homebrew.HB, "staticfloat/juliadeps/glpk461", glpkdep, os = :Darwin) | ||
| using BinaryProvider # requires BinaryProvider 0.3.0 or later |
There was a problem hiding this comment.
Nit: What's the point for this comment given that this requirement is listed in REQUIRE?
There was a problem hiding this comment.
those were automatically generated by BB to remind me to add to REQUIRE, which I had forgotten :-)
make sure updated versions of binaries are installed
No description provided.