-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MOI wrapper #150
Add MOI wrapper #150
Conversation
src/MOI_wrapper.jl
Outdated
end | ||
end | ||
|
||
function hessian_lagrangian_structure(model::Optimizer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC NLopt doesn't take hessians, so all of this code can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this is now removed.
src/MOI_wrapper.jl
Outdated
end | ||
end | ||
|
||
function jacobian_structure(model::Optimizer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed? NLopt supports only dense jacobians.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I followed the approach of the MPB wrapper: since MOI gives the jacobian as the nonzero values of the fixed sparsity structure of the jacobian, the indices of this sparsity need to be queried in order to know where these nonzero values should be put in the dense jacobian given by NLopt.
Should be ready to merge :) |
Great work! Could you also update the discussion of MPB in the README? |
Any objection to merge ? |
Go for it |
Largely inspired from the Ipopt wrapper.
Closes #130