Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-gcc binaryBuilder update #148

Merged
merged 20 commits into from
Sep 5, 2019
Merged

Multi-gcc binaryBuilder update #148

merged 20 commits into from
Sep 5, 2019

Conversation

juan-pablo-vielma
Copy link
Contributor

Updates to the multi gcc-version of binarybuilder, but does not add the symlink magic for BLAS libraries as this adds additional complexity that does not seem to be necessary (does not fix the known issues with ArchLinux).

@kalmarek
Copy link
Collaborator

I have a very mimimal patch for SCS.jl to enable scs-2.1.1, but currenty

@juan-pablo-vielma, @blegat do we agree on this plan?

@juan-pablo-vielma
Copy link
Contributor Author

I suggest releasing this PR as v0.5.2 (or v0.6) to have the last version with scs-v2.0.2 that runs with an up to date version of BB (this should be a simple PR whose only visible change is dropping julia 0.6). Then add #147 and scs-v2.1.1 as v0.6 (or v0.7). Maybe even the last two should be different tags (scs-v2.1.1 may require new tests for added features?)

@juan-pablo-vielma
Copy link
Contributor Author

Ok, spoke too soon. Not sure why coverage dropped, but I imagine this PR needs #144 first.

@kalmarek
Copy link
Collaborator

kalmarek commented Jul 13, 2019

coverage is very flaky: e.g. types.jl are still 100% covered, for sure.
If you don't like our planet, you can re-trigger the build, percentages will change ;-)

EDIT: or maybe not, as we can see ;-)

@juan-pablo-vielma
Copy link
Contributor Author

still failing coverage. I released v2.1.1 in SCSBuilder. Tried to test it, but it seems it needs updates to SCS.jl to work.

@blegat
Copy link
Member

blegat commented Jul 14, 2019

It's known that coverage drops when dropping Julia v0.6 because Julia v0.6 was too generous but Julia v1.0 is not generous enough: JuliaCI/Coverage.jl#187
Adding Julia v1.1 an v1.2 might help

@juan-pablo-vielma
Copy link
Contributor Author

Ok, v1.1 and v1.2 also passing, but there is still a drop in coverage

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a drop in coverage

Looking at the uncovered lined, it doesn't make much sense. It's out of the scope of this PR

@blegat
Copy link
Member

blegat commented Aug 19, 2019

@juan-pablo-vielma Can you rebase ? We need to release v0.6.0 so that SCS has a release supporting MOI v0.9. Currently JuMP examples tests are failing because of SCS

@juan-pablo-vielma
Copy link
Contributor Author

Rebasing done.

@blegat
Copy link
Member

blegat commented Sep 5, 2019

LGTM, @kalmarek any objection to merge ?

@kalmarek
Copy link
Collaborator

kalmarek commented Sep 5, 2019

@blegat not at all, I'm looking forward!

@blegat blegat merged commit 9b49597 into jump-dev:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants