Skip to content

Commit

Permalink
Update composer.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@junaidbhura
junaidbhura authored Sep 11, 2020
1 parent 89f27ef commit 4b045d4
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
{
"name": "junaidbhura/composer-wp-pro-plugins",
"type": "composer-plugin",
"version": "1.0.8",
"version": "1.0.9",
"license": "MIT",
"require": {
"vlucas/phpdotenv": "^4.1.0",
"composer-plugin-api": "^1.1"
Expand Down

4 comments on commit 4b045d4

@szepeviktor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junaidbhura Maybe it is not a good idea to store version number in a library.
https://getcomposer.org/doc/04-schema.md#version

Please consider running composer validate --strict

@junaidbhura
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out @szepeviktor ! Let me do a bit of reading about this!

@mcaskill
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second the motion. Composer/Packagist relies on git tags to manage versioning. You can set this up via GitHub webhooks.

@junaidbhura
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcaskill done! :)

Please sign in to comment.