Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Wpml does not comply with psr-4 autoloading standard #54

Closed
Twansparant opened this issue Mar 7, 2023 · 7 comments
Closed

Class Wpml does not comply with psr-4 autoloading standard #54

Twansparant opened this issue Mar 7, 2023 · 7 comments

Comments

@Twansparant
Copy link

Hi Junaid,

Really happy to see WPML support in your latest release, awesome!
However when I upgrade to the latest version, I get this warning:

Class Junaidbhura\Composer\WPProPlugins\Plugins\Wpml located in ./vendor/junaidbhura/composer-wp-pro-plugins/plugins/WPML.php does not comply with psr-4 autoloading standard. Skipping.

Are you already aware of this?

@mcaskill
Copy link
Contributor

mcaskill commented Mar 7, 2023

Huh. I thought I renamed the file accordingly.
Git or my non-case-sensitive OS must not have taken my file rename seriously.

@mcaskill
Copy link
Contributor

mcaskill commented Mar 8, 2023

@junaidbhura When you have a chance, can you rename the file to match the class name?

I don't think we need a pull request to resolve this mistake. Furthermore, if you want, you can add me as a maintainer to help out.

mcaskill added a commit to mcaskill/composer-wp-pro-plugins that referenced this issue Mar 8, 2023
@mattneal-stafflink
Copy link

+1 for fixing this. No biggie, but still!

@junaidbhura
Copy link
Owner

Hey @Twansparant a new version 1.8.0 has been released. Can you check if that release fixes this issue?

@Twansparant
Copy link
Author

Can you check if that release fixes this issue?

I don't see that warning anymore when running composer update so I guess it's fixed! Thanks!

@mattneal-stafflink
Copy link

Can you check if that release fixes this issue?

I don't see that warning anymore when running composer update so I guess it's fixed! Thanks!

Same :)

@junaidbhura
Copy link
Owner

Great! Props to @szepeviktor for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants