Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to latest DotEnv and also add support for Polylang Woocommerce #4

Closed
wants to merge 2 commits into from

Conversation

danielglans
Copy link

No description provided.

@mcaskill
Copy link
Contributor

👍

Thanks for this but:

  1. The update to DotEnv and the added support for PLL/WC should be two separate pull requests
  2. The package vendor should not change in the composer.json

@danielglans
Copy link
Author

Oh sorry, i haven't quite got the hang of how to do this the right way.. Do you want me to remove this and add a new pull request?

@mcaskill
Copy link
Contributor

I'm sorry for not providing more details. Since this is a pull request from your fork's master branch, I would recommend:

  1. Create a new branch for the DotEnv update from junaidbhura:master then make a pull request for it.
  2. Create a new branch for the Polylang Woocommerce support from junaidbhura:master then make a pull request for it.
  3. Close this pull request with a comment mentioning the new ones.

This way you can preserver your bechwebbkonsult:master branch which you are probably using right now.

@danielglans
Copy link
Author

Okey, great! Thank you so much for the information @mcaskill

@mcaskill
Copy link
Contributor

Cheers!

@junaidbhura
Copy link
Owner

Haha appreciate this. Closing this PR in anticipation of your other PRs, as discussed in the comments. Please do not update the composer.json file.

@mcaskill
Copy link
Contributor

Well, yes, update the composer.json, but only to require the ^3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants