Convert EDD plugins from POST to GET #40
Conversation
| public function get( $url = '', $args = array() ) { | ||
| $query_string = ''; | ||
|
|
||
| $curl_handle = curl_init(); |
There was a problem hiding this comment.
@jessedyck Have you tested this on Windows? I remember facing an issue with the POST request.
|
Thanks a bunch for your PR, @jessedyck ! Could you please elaborate in what environments / Operating Systems you've tested your changes? |
|
@jessedyck I've merged this PR and made the updates. However, it looks like WP All Import / Export have recently started using Cloudflare, so we're unable to download from the command line at the moment, so I've not created a release just yet! |
|
That may explain a change in behaviour I noticed recently; any request would return a download link, regardless of license key. That doesn’t match the expected behaviour from the EDD docs though. I haven’t had a chance to revisit, but perhaps it was cloudflare caching the response then. I’ll try to take a peak soon! |
|
That's odd @jessedyck I went ahead and did a release: https://github.com/junaidbhura/composer-wp-pro-plugins/releases/tag/1.5.0 hoping to see if I'd have luck in CI environments, but no dice! I hope they fix the Cloudflare thing soon. |
Checklist:
Description
Updated EDD plugins, Polylang and WPAll Import, to use GET requests when calling the software licensing API to get the URL of the download. Fixes #27
How has this been tested?
✅ Tested installing WP All Import with valid key
🚫 Polylang was not tested - I don't have a license. Would be great to get that tested prior to merging.
Types of changes