Removed Comparators.reverse(); it's broken and the JDK provides a bet…

…ter version
junit-team · Jun 2, 2018 · 3e6d464 · 3e6d464
1 parent ca3e040
commit 3e6d464
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 11 deletions.
diff --git a/src/test/java/org/junit/tests/manipulation/Comparators.java b/src/test/java/org/junit/tests/manipulation/Comparators.java
@@ -16,12 +16,4 @@ private Comparators() {}
     public static Comparator<Description> alphanumeric() {
         return ALPHANUMERIC;
     }
-
-    public static Comparator<Description> reverse(final Comparator<Description> comparator) {
-        return new Comparator<Description>() {
-            public int compare(Description o1, Description o2) {
-                return ALPHANUMERIC.compare(o2, o1);
-            }
-        };
-    }
 }
diff --git a/src/test/java/org/junit/tests/manipulation/ReverseAlphanumericOrdering.java b/src/test/java/org/junit/tests/manipulation/ReverseAlphanumericOrdering.java
@@ -1,5 +1,7 @@
 package org.junit.tests.manipulation;
 
+import static java.util.Collections.reverseOrder;
+
 import org.junit.runner.manipulation.Ordering;
 
 /**
@@ -9,7 +11,7 @@ public final class ReverseAlphanumericOrdering extends ComparatorBasedOrdering
         implements Ordering.Factory {
 
     public ReverseAlphanumericOrdering() {
-        super(Comparators.reverse(Comparators.alphanumeric()));
+        super(reverseOrder(Comparators.alphanumeric()));
     }
 
     public Ordering create(Context context) {

diff --git a/src/test/java/org/junit/tests/manipulation/ReverseAlphanumericSorter.java b/src/test/java/org/junit/tests/manipulation/ReverseAlphanumericSorter.java
@@ -1,5 +1,7 @@
 package org.junit.tests.manipulation;
 
+import static java.util.Collections.reverseOrder;
+
 import org.junit.runner.manipulation.Ordering;
 import org.junit.runner.manipulation.Sorter;
 
@@ -9,6 +11,6 @@
 public final class ReverseAlphanumericSorter implements Ordering.Factory {
 
     public Ordering create(Ordering.Context context) {
-        return new Sorter(Comparators.reverse(Comparators.alphanumeric()));
+        return new Sorter(reverseOrder(Comparators.alphanumeric()));
     }
 }
diff --git a/src/test/java/org/junit/tests/manipulation/SortableTest.java b/src/test/java/org/junit/tests/manipulation/SortableTest.java
@@ -1,5 +1,6 @@
 package org.junit.tests.manipulation;
 
+import static java.util.Collections.reverseOrder;
 import static org.junit.Assert.assertEquals;
 
 import java.util.Comparator;
@@ -26,7 +27,7 @@ private static Comparator<Description> forward() {
     }
 
     private static Comparator<Description> backward() {
-        return Comparators.reverse(Comparators.alphanumeric());
+        return reverseOrder(Comparators.alphanumeric());
     }
 
     public static class TestClassRunnerIsSortable {