Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use markdown-it-docutils instead of markdown-it-myst #14

Closed
choldgraf opened this issue Jan 19, 2022 · 3 comments
Closed

Use markdown-it-docutils instead of markdown-it-myst #14

choldgraf opened this issue Jan 19, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@choldgraf
Copy link

choldgraf commented Jan 19, 2022

Describe the problem/need and solution

This package currently uses markdown-it-myst for myst parsing and rendering in JupyterLab.

However, more recent development for the "MyST in Javascript" story has been happening over in markdown-it-docutils. This implements the logic for roles/behaviors with MyST.

We should try re-using that package here, since it will likely see the majority of development in the future (markdown-it-myst might even be ready to deprecate, I am not sure?)

Guide for implementation

For some other re-uses of markdown-it-docutils, check out executablebooks/myst-vs-code@master/src/extension.ts, to create https://marketplace.visualstudio.com/items?itemName=ExecutableBookProject.myst-highlight.

Tasks and updates

No response

@choldgraf choldgraf added the enhancement New feature or request label Jan 19, 2022
@chrisjsewell
Copy link

Yep 👍 my thinking was if markdown-it-myst my still be useful to "centralise" things, and minimise any code duplication between jupyterlab-myst and myst-vs-code (or indeed any other JavaScript implementation)?

@chrisjsewell
Copy link

It would be great if jupyterlab-myst could also have the configuration for the syntax exetensions, like myst-vs-code has.

@agoose77
Copy link
Collaborator

It would be great if jupyterlab-myst could also have the configuration for the syntax exetensions, like myst-vs-code has.

Could you elaborate on this? :)

rowanc1 added a commit that referenced this issue Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants