Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Use Remix v2 (Classic Compiler) (2) #409

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Jun 20, 2024

This PR builds upon #408 and actually switches to Remix V2, using the classic remix compiler. A future PR would need to be used to pull in the Vite compiler.

This PR doesn't try to fix the problem with static exports.

@agoose77
Copy link
Collaborator Author

@rowanc1 can you elaborate on the redirect bug you saw? Was it for deployed static sites rather than those run from npx serve locally?

@rowanc1
Copy link
Collaborator

rowanc1 commented Jun 20, 2024

If you npx serve the built html, landing on any page would go into an infinite reload loop. It is very obvious.

It may only be the case if you change the base path?

E.g. BASE_URL=/_build/html

And then serve from the project directory.

The json that remix sends us seen to be invalid, because we changed it, and then it goes into a loop. Possible that that has been fixed as we are skipping many versions.

@agoose77
Copy link
Collaborator Author

I can confirm that I'm seeing the continuous loop behaviour that you reported for 1.1.18 in version 2.x. It looks like we might need to consider the other routes to static exports (like SSG SPA that I linked previously).

@rowanc1
Copy link
Collaborator

rowanc1 commented Jun 20, 2024

Very unfortunate. :(

@agoose77
Copy link
Collaborator Author

I have a stupid idea for upgrading to v2 before we have implemented SSG - mpa-spa. Could we run the MyST server at the same base path such that the hydrated document matches the SSR?

@rowanc1
Copy link
Collaborator

rowanc1 commented Jun 20, 2024

Maybe? I think that would be just changing the request coming in (i.e. _build/html/slug) and then in the loader ensuring that matches.

@agoose77 agoose77 changed the title ⬆️ Use Remix V2 ⬆️ Use Remix v2 (Classic Compiler) Jun 21, 2024
@agoose77 agoose77 changed the title ⬆️ Use Remix v2 (Classic Compiler) ⬆️ Use Remix v2 (Classic Compiler) (2) Jun 21, 2024
@agoose77 agoose77 marked this pull request as ready for review June 24, 2024 09:56
@agoose77 agoose77 changed the base branch from main to agoose77/refactor-prepare-for-v2 August 8, 2024 13:20
Base automatically changed from agoose77/refactor-prepare-for-v2 to main August 26, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants