🌗 Remote CDN and theme button for the article theme #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update for both article/book themes - Update dev documentation
🦋 Changeset detectedLatest commit: b71b6b1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rowanc1
approved these changes
Sep 13, 2024
| @@ -11,7 +11,7 @@ import { | |||
| import { responseNoArticle, responseNoSite, getDomainFromRequest } from '@myst-theme/site'; | |||
|
|
|||
| const CONTENT_CDN_PORT = process.env.CONTENT_CDN_PORT ?? '3100'; | |||
| const CONTENT_CDN = `http://localhost:${CONTENT_CDN_PORT}`; | |||
| const CONTENT_CDN = process.env.CONTENT_CDN ?? `http://localhost:${CONTENT_CDN_PORT}`; | |||
rowanc1
changed the title
|
Thanks for the changes @agahkarakuzu -- really awesome to have you contributing here. Excited to see your launch in a few weeks. 🚀 |
|
Thank you so much @rowanc1! The event will be much cooler thanks to all the amazing effort you've put in this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342.
ThemeButtonto the article theme. Tested locally:CONTENT_CDNthrough env to replacelocalhost:{port}withhttps://remote.example.com.Note
Right before opening this PR, I realized that a similar PR #346 exists, enabling
{hostname}:{port}. This is slightly different as the purpose is to connect to a remote CDN host (tested withhttps://cdn.neurolibre.org) without specifying a port. Happy to account for the changes from #346 to avoid conflict.