Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏫 Add reviewers and editors to frontmatter #1036

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Mar 28, 2024

This reuses the same stash infrastructure that as funding recipients/investigators.

On the final resolved frontmatter, editors and reviewers are lists of string ids which index into contributors and authors (each of those is still a full object).

(The actual editor/reviewer changes are pretty straightforward frontmatter updates - there was just another related edge case I ironed out to slightly complicate things...)

(This addresses a point in #1009)

@fwkoch fwkoch mentioned this pull request Mar 28, 2024
16 tasks
Copy link
Collaborator

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked through the demos locally! Works well. 🚀

@fwkoch
Copy link
Collaborator Author

fwkoch commented Mar 28, 2024

The changes I made to reduce unnecessary warnings still come up in cases where contributors are defined across project/page, so I'm going to back out those changes before I proceed. I'll just also remove the warning that was appearing about "no given name"

@fwkoch fwkoch merged commit 62620a8 into main Mar 28, 2024
4 checks passed
@fwkoch fwkoch deleted the feat/reviewer-editor branch March 28, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants