Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 Validate site action urls later and infer static #1048

Closed
wants to merge 3 commits into from

Conversation

fwkoch
Copy link
Collaborator

@fwkoch fwkoch commented Apr 2, 2024

Site actions may be either static files, relative urls, or external urls. Previously, if static: true was specified and a file did not exist, the entire build failed. Also, if a local static file was specified but static: true was not, validation failed.

Now, action validation is a bit less strict and a bit more helpful:

  • If the action points to an existing local file, static: true is inferred
  • If the action says static: true but the file does not exist, it still logs an error, but the build continues
  • If the action does not look like a URL or a local file, it warns, but the build continues.

@fwkoch fwkoch mentioned this pull request Apr 2, 2024
16 tasks
@fwkoch
Copy link
Collaborator Author

fwkoch commented Apr 4, 2024

The changes here became useful when working on this feature: #1049 - so everything is combined over there, and I'm closing this PR in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant