Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔭 Trim spaces in bibtex URLs and DOIs #1411

Merged
merged 3 commits into from
Aug 8, 2024
Merged

🔭 Trim spaces in bibtex URLs and DOIs #1411

merged 3 commits into from
Aug 8, 2024

Conversation

rowanc1
Copy link
Collaborator

@rowanc1 rowanc1 commented Jul 25, 2024

No description provided.

Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: dbc4d2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
citation-js-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@fwkoch fwkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice - I'm wondering if we could be even more liberal with trimming other fields? For example, this bibtex is rendered with extra spaces (besides the DOI space which this PR should address):

image

@rowanc1
Copy link
Collaborator Author

rowanc1 commented Aug 8, 2024

Updated!

@rowanc1 rowanc1 merged commit 1ac4d7a into main Aug 8, 2024
7 checks passed
@rowanc1 rowanc1 deleted the bibtex/spaces branch August 8, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants